Skip to content

chore(translations): remove or blank unused strings#6934

Open
Thalarion wants to merge 3 commits into
mainfrom
thalarion/2605_remove_or_blank_unused_strings
Open

chore(translations): remove or blank unused strings#6934
Thalarion wants to merge 3 commits into
mainfrom
thalarion/2605_remove_or_blank_unused_strings

Conversation

@Thalarion
Copy link
Copy Markdown
Contributor

@Thalarion Thalarion commented May 15, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026 •
edited
Loading

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ca99fc2-0d20-4833-af2b-b846e0140d7d

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27d5d and 6ebfb26.

⛔ Files ignored due to path filters (1)
  • core/embed/rust/src/translations/generated/translated_string.rs is excluded by !**/generated/**
📒 Files selected for processing (4)
  • core/embed/rust/librust_qstr.h
  • core/mocks/trezortranslate_keys.pyi
  • core/translations/blank_translations_rules.json
  • core/translations/en.json
💤 Files with no reviewable changes (2)
  • core/embed/rust/librust_qstr.h
  • core/mocks/trezortranslate_keys.pyi

Walkthrough

This PR removes four deprecated translation identifiers from MicroPython QSTR registration and translation stubs, adds two new coinjoin-related translation keys, and restructures English translation entries to support per-device text variants. The changes update blank translation rules to specify which keys are empty for specific device layouts (Bolt, Caesar, Delizia, Eckhart), converting 22 existing translation keys from single strings to variant objects with conditional text per device.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only a template with no actual content describing the changes, rationale, testing, or PR setup instructions required by the template. Replace the template placeholder with a substantive description of changes, commit progression, testing performed, and complete the required core-developer checklist items (assignment, project setup, status, QA notes if applicable).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing or blanking unused translation strings, which aligns with the file modifications in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thalarion/2605_remove_or_blank_unused_strings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware May 15, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware May 15, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026 •
edited
Loading

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)

Latest CI run: 25923284223

@Thalarion Thalarion changed the title Thalarion/2605 remove or blank unused strings chore(translations): remove or blank unused strings May 15, 2026
@Thalarion Thalarion force-pushed the thalarion/2605_remove_or_blank_unused_strings branch from 626dc7f to 6ebfb26 Compare May 15, 2026 14:28
@Thalarion Thalarion requested a review from romanz May 15, 2026 14:28
@Thalarion Thalarion marked this pull request as ready for review May 15, 2026 14:28
obrusvit
obrusvit reviewed May 15, 2026
View reviewed changes
Comment thread core/translations/en.json
"fido__title_register": "FIDO2 register",
"fido__title_remove_credential": "Remove credential",
"fido__title_reset": "FIDO2 reset",
"fido__title_reset": {
Copy link
Copy Markdown
Contributor

@obrusvit obrusvit May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about removing fido__ until we have proper UI tests in place.

Could it be a culprit of the recent bug with the FIDO button shown by @romanz ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obrusvit obrusvit obrusvit left review comments

@romanz romanz Awaiting requested review from romanz

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Thalarion Thalarion

Labels

None yet

Projects

Firmware
Status: 🔎 Needs review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Thalarion @obrusvit